Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add jplag frontend #873

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

JackSCarroll
Copy link

Depends on doubtfire-lms/doubtfire-deploy#28
Depends on doubtfire-lms/doubtfire-api#447
Feasibility document: thoth-tech/documentation#528

Description

Added frontend UI to allow authorised users to download JPLAG reports for a task in a unit.
Button can be found in task explorer screen and clicking the three dots.
Using task filter allows you to download the report for each task.
image

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Testing Checklist:

  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • My changes generate no new warnings

Copy link
Member

@macite macite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do JPLAG similarities appear when we switch into the similarity view?

@@ -108,6 +108,10 @@
<mat-icon matListItemIcon aria-label="View Similarities">crisis_alert</mat-icon>
View similarities
</button>
<button mat-menu-item (click)="downloadJPLAGReport()">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide this if there is no code similarity checks for the task definition

@@ -74,6 +79,10 @@
<mat-icon>download</mat-icon>
<span>Bulk Export Submission Files</span>
</button>
<button mat-menu-item (click)="downloadJPLAGReport()">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide this if the task def does not have code similarity checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants